Skip to content

fix wrongly running macos workflow on ubuntu-latest + formatting #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 7, 2025

Conversation

abebus
Copy link
Contributor

@abebus abebus commented Jul 27, 2025

No description provided.

Copy link

codecov bot commented Jul 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.96%. Comparing base (f45e3ff) to head (a75f303).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #248   +/-   ##
=======================================
  Coverage   97.96%   97.96%           
=======================================
  Files           9        9           
  Lines         491      491           
  Branches       83       83           
=======================================
  Hits          481      481           
  Misses          6        6           
  Partials        4        4           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@abebus abebus force-pushed the fix-macos-workflow branch from e65fc3b to 0cd04bc Compare July 27, 2025 20:31
@abebus abebus force-pushed the fix-macos-workflow branch from 0cd04bc to 6e349ce Compare July 27, 2025 20:32
@abebus
Copy link
Contributor Author

abebus commented Jul 27, 2025

Should macOS-13 (the latest macOS GH runner with x86 arch) even be included at all?

…of consistency, due to the interesting relationship of YAML with fractional numbers. Format all workflow files with the `redhat.vscode-yaml

⁣` VS Code extension. I believe it can be done with CLI or in a pre-commit hook or in a tox step; it needs investigation.

runs-on: ubuntu-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t love the formatting, but I am OK with it as long as we extend the pre-commit config to apply it automatically to every YAML file in the repo, e.g. with https://github.com/google/yamlfmt.

@abebus
Copy link
Contributor Author

abebus commented Aug 6, 2025

Google's yamlfmt requires golang to be installed, so I chose this, which doesn't require extra dependencies

@abebus
Copy link
Contributor Author

abebus commented Aug 6, 2025

@wRAR @Gallaecio should I set indentation to 2 instead of the tool's default 4?

@Gallaecio
Copy link
Member

Gallaecio commented Aug 7, 2025

Yes, I think the closer to the original formatting, the better.

I also would like not to have the --- stuff at the beginning, specially because I have seen that fail on YAML readers that do not expect or support it, but I don’t see an option to turn that off in that hook :(

Given how more complete Google’s options look, I wonder if getting go installed in the CI would not be worth it. No strong opinion, though, I get it is weird to start asking every w3lib contributor to install Go.

@wRAR
Copy link
Member

wRAR commented Aug 7, 2025

I don't have preferences for a yaml formatting style so anything works for me :)

@Gallaecio
Copy link
Member

OK, lets merge as it is. Assuming the --- do not break anything, we can adjust things further in the future if someone feels strongly enough about it.

@Gallaecio Gallaecio merged commit 0e2f11c into scrapy:master Aug 7, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants