-
Notifications
You must be signed in to change notification settings - Fork 108
fix wrongly running macos workflow on ubuntu-latest + formatting #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #248 +/- ##
=======================================
Coverage 97.96% 97.96%
=======================================
Files 9 9
Lines 491 491
Branches 83 83
=======================================
Hits 481 481
Misses 6 6
Partials 4 4 🚀 New features to boost your workflow:
|
e65fc3b
to
0cd04bc
Compare
0cd04bc
to
6e349ce
Compare
Should macOS-13 (the latest macOS GH runner with x86 arch) even be included at all? |
…of consistency, due to the interesting relationship of YAML with fractional numbers. Format all workflow files with the `redhat.vscode-yaml ` VS Code extension. I believe it can be done with CLI or in a pre-commit hook or in a tox step; it needs investigation.
|
||
runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t love the formatting, but I am OK with it as long as we extend the pre-commit config to apply it automatically to every YAML file in the repo, e.g. with https://github.com/google/yamlfmt.
… gh workflows, so yamllint will allow "on" as key
Google's |
@wRAR @Gallaecio should I set indentation to 2 instead of the tool's default 4? |
Yes, I think the closer to the original formatting, the better. I also would like not to have the Given how more complete Google’s options look, I wonder if getting go installed in the CI would not be worth it. No strong opinion, though, I get it is weird to start asking every w3lib contributor to install Go. |
I don't have preferences for a yaml formatting style so anything works for me :) |
OK, lets merge as it is. Assuming the |
No description provided.